[PATCH 0/6] Share memory searching code between gdb and gdbserver
Gary Benson
gbenson@redhat.com
Thu Jul 30 12:07:01 GMT 2020
Tom Tromey wrote:
> I happened to look at the memory searching code in gdb, and at the
> bugs reported for the "find" command, and this series is the result.
>
> The bulk of the change here is to share the underlying memory
> searching implementation between gdb and gdbserver. I did this in
> anticipation of having to fix bugs in two nearly identical functions.
>
> However, after doing so, I was unable to reproduce either of the
> failures on file. I did add a unit test to make this easier to test
> later on.
>
> Regression tested on x86-64 Fedora 32. I also tested find.exp and
> find-unmapped.exp using gdbserver.
>
> Let me know what you think.
LGTM. And gold stars for deduplicating stuff :D
Cheers,
Gary
--
Gary Benson - he / him / his
Principal Software Engineer, Red Hat
More information about the Gdb-patches
mailing list