[PATCH] Unify Solaris procfs and largefile handling
Simon Marchi
simark@simark.ca
Tue Jul 28 14:17:22 GMT 2020
On 2020-07-28 9:51 a.m., Rainer Orth wrote:
> Unfortunately not: <sys/procfs.h> is sometimes used in code shared with
> non-Solaris systems, none of which have <procfs.h>. So we'd have to
> conditionalize on HAVE_PROCFS_H vs. HAVE_SYS_PROCFS_H.
>
> And on older Solaris 11.3, even when using the new procfs interface,
> <sys/procfs.h> errors out when largefile support is enabled.
>
> As I said: it's a royal mess ;-(
>
> Rainer
Ok, I see.
The only part I'm not sure about is the part that adds --enable-gdb to all configure
files. For example we now have this in bfd's configure:
$ ./binutils/configure --help | grep gdb
--enable-gdb[=ARG] build gdb [ARG={yes,no}]
I understand that you want to catch whether the user enabled or disabled building GDB
with --enable-gdb or --disable-gdb, but the result is a bit weird. Is there a way not
to include it in the --help?
Ideally, the top-level configure system would be able to tell which modules are enabled.
I don't know much about it, maybe there's a way.
In your patch, can
: ${enable_largefile="no"}
become just
enable_largefile="no"
?
Simon
More information about the Gdb-patches
mailing list