GDB 10 branching - 2020-07-26 update

[Hannes Domani]

 Am Montag, 27. Juli 2020, 01:45:58 MESZ hat Joel Brobecker <brobecker@adacore.com> Folgendes geschrieben:

> Here is a quick recap of where we are with respect to the GDB 10
> release. We did well this week, with getting 5 entries out of the way,
> and with only 2 being added (knowing that patches for those have
> already been sent).
>
> I'm concerned about two entries:
>
>   * [TomT/HannesD] <PR win32/25302>
>     Mismatching fstat() function calls in gdb_bfd_open() and cache_bstat()
>     https://sourceware.org/bugzilla/show_bug.cgi?id=25302
>
>         I'm wondering if we should be setting up a live discussion
>         to first recap, and then answer Pedro's questions about
>         Tom's comments on his current patch.
>
>         This one triggers a crash, so it's hard to consider releasing
>         without it :-(.

If all else fails, you might want to consider the workaround I use, and
which I described in my initial bug report:

--- a/gdb/gdb_bfd.c
+++ b/gdb/gdb_bfd.c
@@ -384,6 +384,11 @@ gdb_bfd_iovec_fileio_fstat (struct bfd *abfd, void *stream,
 
 /* See gdb_bfd.h.  */
 
+#pragma push_macro("fstat")
+#pragma push_macro("stat")
+#undef fstat
+#undef stat
+
 gdb_bfd_ref_ptr
 gdb_bfd_open (const char *name, const char *target, int fd,
           bool warn_if_slow)
@@ -480,6 +485,9 @@ gdb_bfd_open (const char *name, const char *target, int fd,
   return gdb_bfd_ref_ptr::new_reference (abfd);
 }
 
+#pragma pop_macro("fstat")
+#pragma pop_macro("stat")
+
 /* A helper function that releases any section data attached to the
    BFD.  */
 

This solves at least the crash problem.


Hannes