[PATCH] gdb/disassembly: Update to handle non-statement addresses

[Pedro Alves]

On 7/23/20 9:48 AM, Andrew Burgess wrote:

> FYI, I don't really consider /m "deprecated".  We don't have any plan
> for how we could ever remove /m from GDB, so it's probably going to
> live on forever.  That doesn't really feel like something that's
> deprecated to me, just something that got known issues.

Note that "help disassemble" explicitly says that it is deprecated:

 With a /m modifier, source lines are included (if available).
 This view is "source centric": the output is in source line order,
 regardless of any optimization that is present.  Only the main source file
 is displayed, not those of, e.g., any inlined functions.
 This modifier hasn't proved useful in practice and is deprecated
                                                       ^^^^^^^^^^
 in favor of /s.

 With a /s modifier, source lines are included (if available).
 This differs from /m in two important respects:
 - the output is still in pc address order, and
 - file names and contents for all relevant source files are displayed.

I've always thought that these two paragraphs are backwards -- i.e.,
that we should describe /s first since it's the preferred format,
and then /m should be described in comparison to /s.

> FYI(2), I only use /s myself because /m is junk :)