[PATCH v3 1/9] gdb/jit: pass the jiter objfile as an argument to jit_event_handler

[Aktemur, Tankut Baris]

On Wednesday, July 15, 2020 3:49 PM, Simon Marchi wrote:
> On 2020-07-15 4:16 a.m., Tankut Baris Aktemur wrote:
> > diff --git a/gdb/jit.h b/gdb/jit.h
> > index cc135037812..dddded0236f 100644
> > --- a/gdb/jit.h
> > +++ b/gdb/jit.h
> > @@ -20,6 +20,8 @@
> >  #ifndef JIT_H
> >  #define JIT_H
> >
> > +#include "objfiles.h"
> 
> It's preferable to use forward declarations when possible:
> 
> struct objfile;

Fixed in v4.

> > +
> >  /* When the JIT breakpoint fires, the inferior wants us to take one of
> >     these actions.  These values are used by the inferior, so the
> >     values of these enums cannot be changed.  */
> > @@ -78,6 +80,6 @@ extern void jit_breakpoint_re_set (void);
> >  /* This function is called by handle_inferior_event when it decides
> >     that the JIT event breakpoint has fired.  */
> 
> Can you document the new parameter?  I suppose it would be something like
> "JITER is the objfiles whose JIT event breakpoint has been hit".

Added the comment in v4.

Thanks
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928