[PATCH v4 1/2] guile: Add support for Guile 2.2.

Simon Marchi simark@simark.ca
Mon Jul 20 15:01:42 GMT 2020


On 2020-07-20 4:05 a.m., Ludovic Courtès wrote:
> Hi Simon,
> 
> Simon Marchi <simark@simark.ca> skribis:
> 
>> On 2020-07-18 3:00 p.m., Joel Brobecker wrote:
>>> Hi Simon,
>>>
>>>>> This primarily updates code that uses the I/O port API of Guile.
>>>>
>>>> I know nothing about Guile, so I just scanned the patch for any obvious
>>>> red flags, but didn't see any.  The mess of #if statements sure is not
>>>> the best, but I don't have a concrete suggestion to make it better.
>>>
>>> I'm not confident that we'll be able to find a reviewer who has
>>> more experience with this part of the Code. What do you think of
>>> approving this patch series based on your review?
>>
>> Yeah, I think we can go ahead.  Ludovic, do you have push access or would you like me to push it?
> 
> I do have access but I’m happy if you can push it for me.

Done, thanks.

Simon


More information about the Gdb-patches mailing list