[PATCH 2/2] gdb/python: Reuse gdb.RegisterGroup objects where possible
Tom Tromey
tom@tromey.com
Mon Jul 13 18:23:27 GMT 2020
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> gdb/ChangeLog:
Andrew> * python/py-registers.c : Add 'unordered_map' include.
Andrew> (gdbpy_new_reggroup): Renamed to...
Andrew> (gdbpy_get_reggroup): ...this. Update to only create register
Andrew> group descriptors when needed.
Andrew> (gdbpy_reggroup_iter_next): Update.
The idea looks good to me.
Andrew> + /* Map from GDB's internal reggroup objects to the Python representation.
Andrew> + GDB's reggroups are global, and are never deleted, so using a map like
Andrew> + this is safe. */
Andrew> + static std::unordered_map<struct reggroup *,const reggroup_object *>
Andrew> + gdbpy_reggroup_object_map;
The same comment about "const", etc, applies here as in the previous
patch.
Tom
More information about the Gdb-patches
mailing list