[PATCH 0/7] Add gdb support for Cygwin x86_64 core dumps

[Simon Marchi]

On 2020-07-01 5:32 p.m., Jon Turney wrote:
> As far as I know, the only way to generate these "core dumps" is to use
> Cygwin's 'dumper' tool, which requires some fixes on x86_64 [1].
> 
> [1] https://cygwin.com/pipermail/cygwin-patches/2020q3/010313.html
> 
> Jon Turney (7):
>   Read tid from correct offset in win32pstatus NOTE_INFO_THREAD
>   Don't apply size constraint to all win32pstatus ELF notes.
>   Don't hardcode CONTEXT size for a NOTE_INFO_THREAD win32pstatus note
>   Add sniffer for Cygwin x86_64 core dumps
>   Add amd64_windows_gregset_reg_offset
>   Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str
>   Add handling for 64-bit module addresses in Cygwin core dumps
> 
>  bfd/ChangeLog            |  20 ++++++++
>  bfd/elf.c                |  25 +++++----
>  gdb/ChangeLog            |  23 +++++++++
>  gdb/amd64-windows-tdep.c | 100 ++++++++++++++++++++++++++++++++++++
>  gdb/i386-windows-tdep.c  | 100 +-----------------------------------
>  gdb/windows-tdep.c       | 108 +++++++++++++++++++++++++++++++++++++++
>  gdb/windows-tdep.h       |   8 +++
>  7 files changed, 276 insertions(+), 108 deletions(-)
> 
> -- 
> 2.27.0
> 

I've sent a few comments, but in general the GDB bits look fine to me.  But
as Tom said, the bfd bits need to be approved by the binutils folks.

Simon