[PATCH 6/7] Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str

[Simon Marchi]

On 2020-07-02 7:53 p.m., Simon Marchi wrote:
> On 2020-07-01 5:32 p.m., Jon Turney wrote:
>> Move windows_core_xfer_shared_libraries() and windows_core_pid_to_str()
>> to windows-tdep, use in amd64-windows-tdep.c to handle Cygwin x86_64
>> core dumps.
> 
> As a convention, the _initialize function is always at the bottom of the file,
> so I'd put the new functions in windows-tdep.c just above it.
> 
> Were the functions copied as-is, or did you need to make changes to support 64-bits?
> 
> Simon
> 

Well, right after writing this I saw patch 7, "Add handling for 64-bit module addresses
in Cygwin core dumps".  Now you know that I read series in a very linear fashion :).

So, I suppose that in this patch, the functions are copied as-is, and are not suitable
yet for the 64-bit cores?

Simon