[PATCH 12/55] Introduce value_print_scalar_formatted

Simon Marchi simark@simark.ca
Wed Jan 15 05:15:00 GMT 2020


On 2019-12-08 1:29 p.m., Tom Tromey wrote:
> diff --git a/gdb/valprint.h b/gdb/valprint.h
> index e4b90404fa2..f1c93aa26b6 100644
> --- a/gdb/valprint.h
> +++ b/gdb/valprint.h
> @@ -141,6 +141,16 @@ extern void val_print_scalar_formatted (struct type *,
>  					int,
>  					struct ui_file *);
>  
> +/* Print a scalar according to OPTIONS and SIZE on STREAM.  Format i
> +   is not supported at this level.

There seems to be a typo above, "Format i".

> +
> +   This is how the elements of an array or structure are printed
> +   with a format.  */
> +
> +extern void value_print_scalar_formatted (struct value *,
> +					  const struct value_print_options *,
> +					  int, struct ui_file *);
> +

I think you should add the parameter names here, especially since the comment
refers to them.

Simon



More information about the Gdb-patches mailing list