[PATCH] Make skip without argument skip the current inline function
Simon Marchi
simark@simark.ca
Tue Jan 14 04:20:00 GMT 2020
On 2019-12-28 8:30 a.m., Bernd Edlinger wrote:
> Hi,
>
> this would in a way complete the skip inlined function feature.
> That is make the skip command, when used without arguments, figure
> out if there is an inlined function currently executing, and skip
> that in future.
>
> Well, not sure if that is worth a mention in the NEWS, maybe when the
> remaining patch 'Fix an issue with the gdb step-over aka. "n" command'
> which prevents accidentally stepping over a possibly skipped inline
> function accidentally to step back into the inline function again.
>
>
> gdb:
> 2019-12-28 Bernd Edlinger <bernd.edlinger@hotmail.de>
>
> * skip.c (skip_function_command): Make skip w/o arguments use the
> name of the inlined function if pc is inside any inlined function.
>
> gdb/testsuite:
> 2019-12-28 Bernd Edlinger <bernd.edlinger@hotmail.de>
>
> * gdb.base/skip-inline.exp: Extend test.
>
>
> Thanks
> Bernd.
Hi Bernd,
In my opinion, the current behavior is simply a bug. As a user, I would expect
the selected frame to be used, regardless of if it's an inline frame or not.
Therefore I don't think we should put a NEWS entry (we don't do NEWS entries for
bug fixes).
The patch looks good to me though, thanks for that.
Simon
More information about the Gdb-patches
mailing list