[PATCH v3 0/2] Fix handling of null stap semaphores
George Barrett
bob@bob131.so
Fri Jan 10 19:37:00 GMT 2020
GDB's handling of userspace SystemTap probes is currently inconsistent
with the specification of the format[0]: the absence of a semaphore for
a particular probe is recorded within its ELF note by setting the
address value to zero, but the current implementation doesn't check the
value against zero until after a relocation has been applied.
The primary patch in this set is #2 ('Fix handling of null stap
semaphores'). Writing the test case revealed some issues with other
stap-related tests, fixes for which have been split into patch #1 as
suggested in a previous review.
v3 of this patchset carries changes to the test case suggested in a
previous review, namely the removal of an xfail directive and an
additional explanatory comment.
[0]: https://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation
George Barrett (2):
gdb/testsuite/gdb.base/stap-probe: Minor clean-up
Fix handling of null stap semaphores
gdb/stap-probe.c | 7 ++--
gdb/testsuite/gdb.base/stap-probe.c | 4 ++-
gdb/testsuite/gdb.base/stap-probe.exp | 47 ++++++++++++++++++++++-----
3 files changed, 45 insertions(+), 13 deletions(-)
--
2.24.1
More information about the Gdb-patches
mailing list