[PATCH v5] Add debuginfod support to GDB

[Tom de Vries]

On 26-02-2020 23:47, Aaron Merey wrote:
> On Wed, Feb 26, 2020 at 4:52 PM Simon Marchi <simark@simark.ca> wrote:
>> Thanks, this is ready to push.  Do you have push access?  Or maybe Frank can
>> push it for you?
> 
> Great, I've pushed to master.
> 

This caused the following regressions:
...
Running
/data/gdb_versions/devel/src/gdb/testsuite/gdb.dwarf2/dw2-compdir-oldgcc.exp
...
ERROR: GDB process no longer exists
ERROR: Couldn't send info source to GDB.
Running
/data/gdb_versions/devel/src/gdb/testsuite/gdb.python/py-framefilter-invalidarg.exp
...
ERROR: couldn't run to breakpoint
Running
/data/gdb_versions/devel/src/gdb/testsuite/gdb.dwarf2/dw2-ranges-base.exp ...
ERROR: GDB process no longer exists
...

Looking at the dw2-ranges-base one in more detail:
...
$ gdb
build/gdb/testsuite/outputs/gdb.dwarf2/dw2-ranges-base/dw2-ranges-base
-ex start -ex "maint info line-table" -batch
...

We have the backtrace:
...
(gdb) bt
#0  0x00007ffff50842c1 in __strlen_avx2 () from /lib64/libc.so.6
#1  0x00007ffff5638755 in std::__cxx11::basic_string<char,
std::char_traits<char>, std::allocator<char> >::operator=(char const*)
() from /usr/lib64/libstdc++.so.6
#2  0x0000000000880ae7 in open_source_file (s=0x1a14880)
    at /data/gdb_versions/devel/src/gdb/source.c:1165
#3  0x0000000000880c4f in symtab_to_fullname (s=0x1a14880)
    at /data/gdb_versions/devel/src/gdb/source.c:1202
#4  0x00000000008b3fdd in maintenance_print_one_line_table
(symtab=0x1a14880, data=0x0)
    at /data/gdb_versions/devel/src/gdb/symmisc.c:977
...

The problem seems to be here:
...
(gdb)
#2  0x0000000000880ae7 in open_source_file (s=0x1a14880)
    at /data/gdb_versions/devel/src/gdb/source.c:1165
1165                  srcpath = SYMTAB_DIRNAME (s);
(gdb) p s->compunit_symtab->dirname
$3 = 0x0
...

Thanks,
- Tom