[PATCH][gdb] Fix cc-with-dwz regression

Tom Tromey tom@tromey.com
Thu Feb 20 16:43:00 GMT 2020


>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Hi,
Tom> I noticed a regression with board cc-with-dwz:
Tom> ...
Tom> FAIL: gdb.cp/m-static.exp: static const int initialized elsewhere
Tom> FAIL: gdb.cp/m-static.exp: info variable everywhere
Tom> ...

Tom> The problem started with commit 0494dbecdf "Consolidate partial symtab
Tom> dependency reading".

Thank you for doing this.

Tom> The commit replaces the dwarf2_psymtab::expand_psymtab specific reading of
Tom> dependencies, which contains a "dependencies[i]->user == NULL" test, with a
Tom> generic partial_symtab::read_dependencies call, which does not test the user
Tom> field.

Can we simply add this to the base class?
I think only the DWARF reader ever sets the "user" field anyway.

Tom



More information about the Gdb-patches mailing list