[RFC][gdb/testsuite] Ignore pass in gdb_caching_proc

[Tom de Vries]

[ was : Re: [committed][gdb/testsuite] Handle missing gnatmake in
gnat_runtime_has_debug_info ]

On 18-02-2020 10:39, Tom de Vries wrote:
> FWIW, I scanned a bit other gdb_caching_procs and there seems to be an
> idiom to handle hitting the default case of an expect using a warning,
> f.i. in skip_aarch64_sve_tests:
> ...
>         default {
>           warning "\n$me: default case taken"
>             set skip_sve_tests 1
>         }
> ...
> So we could use that at least for the last fail.
> 
> Also, here and there verbose seems to be used instead of fail.
> 
> The gdb_caching_procs seem to avoid explicitly calling pass and fail,
> but usage of gdb_test_multiple does happen a couple of time, which might
> result in fails etc (but then again, that might not have been
> intentional, I'm not sure).
> 
> In any case, we could either:
> - forbid calling pass in gdb_caching_proc, or
> - more accommodatingly, ignore pass in gdb_caching_proc.
> Both by renaming pass in gdb_do_cache.
> 
> Likewise, we could perhaps redirect fails to warnings.

This RFC patch implements "ignore pass in gdb_caching_proc".

Any comments?

Thanks,
- Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gdb-testsuite-Ignore-pass-in-gdb_caching_proc.patch
Type: text/x-patch
Size: 2506 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20200218/7fcdee71/attachment.bin>