[PATCH 01/14] gdb/testsuite: Fix an invalid is_remote check in fileio test

[Shahab Vahedi]

On 2/11/20 8:29 AM, Luis Machado wrote:
> Hi,
> 
> On 2/7/20 11:59 AM, Shahab Vahedi wrote:
>> From: Anton Kolesov <Anton.Kolesov@synopsys.com>
>>
>> Fileio test improperly checks if [is_remote host] and if it is, then
>> uses file path that is safe to use on remote host.  But the problem is
>> that [is_remote host] returns state of *this* host, not of the remote
>> target, where filepaths actually matter.  This patch fixes that.
> 
> Do you remember what that error was? I don't see any errors running on my end. Though the patch doesn't introduce new errors as well.
> 
> Were you using a different board file that exercised gdbserver running on a remote host?

Indeed specific boards for ARC are used. And yes, there were/are 2 ways
that these boards were executed: through a simulator and on real boards
(remote hosts).

> 
> I'm trying to understand what the problem is.
> 
>>
>> gdb/testsuite/ChangeLog:
>> 2016-12-16  Anton Kolesov <Anton.Kolesov@synopsys.com>
>>
>>     * gdb.base/fileio.exp: Use "target" instead of "host".
>>
>> Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
>> ---
>>   gdb/testsuite/gdb.base/fileio.exp | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp
>> index 9735869e5190..627a685e118d 100644
>> --- a/gdb/testsuite/gdb.base/fileio.exp
>> +++ b/gdb/testsuite/gdb.base/fileio.exp
>> @@ -23,7 +23,7 @@ if [target_info exists gdb,nofileio] {
>>     standard_testfile
>>   -if {[is_remote host]} {
>> +if {[is_remote target]} {
>>       set outdir .
>>   } else {
>>       set outdir [standard_output_file {}]
>>