[PATCH] Fix build on macOS

Christian Biesinger via gdb-patches gdb-patches@sourceware.org
Wed Feb 5 18:37:00 GMT 2020


On Fri, Jan 31, 2020 at 4:02 PM Kevin Buettner <kevinb@redhat.com> wrote:
>
> On Fri, 31 Jan 2020 15:43:29 +0100
> Tom Tromey <tromey@adacore.com> wrote:
>
> > >>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
> >
> > >> gdb/ChangeLog
> > >> 2019-12-10  Tom Tromey  <tromey@adacore.com>
> > >>
> > >> PR build/25268:
> > >> * gdbsupport/thread-pool.c (set_thread_name): New template
> > >> function.
> > >> (thread_pool::set_thread_count): Don't call pthread_setname_np.
> > >> (thread_pool::thread_function): Call set_thread_name.
> >
> > Kevin> Did this ever go in?
> >
> > Kevin> If not, I think it looks reasonable.
> >
> > Something like it did, and then there was another fix after that.
>
> Yeah, I saw that there was a second fix, but I didn't see the template
> stuff, which I thought was pretty cool.

The ultimate solution used function overloads instead of templates,
which seems simpler.

Christian



More information about the Gdb-patches mailing list