[review v2] infrun: handle already-exited threads when attempting to stop
Tankut Baris Aktemur (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Mon Feb 3 16:02:00 GMT 2020
Tankut Baris Aktemur has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/133
......................................................................
Patch Set 2:
> > >
> > > FTR, I build patchset 2 and tested the example from PR25478, and hit an assert:
> > > ...
> >
> > I was not able to repeat the problematic scenario with the current master.
>
> Do you mean with 'problematic scenario' PR25478 as such, or the assert?
Sorry for the vagueness. I was referring to the test scenario I gave in the patch
description. Like, scenarios that can be used for testing as in
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/134
without having to stop GDB from outside at 'stop_all_threads'.
I just saw that you posted a rebased version of this patch. I'll look at that,
thank you.
Btw, I think this patch is kind of obsolete after Pedro's comments in
https://sourceware.org/ml/gdb-patches/2020-01/msg00212.html
because the patch causes two stop event reports at once.
-Baris
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I7cec98f40283773b79255d998511da434e9cd408
Gerrit-Change-Number: 133
Gerrit-PatchSet: 2
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-CC: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Mon, 03 Feb 2020 16:02:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
More information about the Gdb-patches
mailing list