[PATCH][gdb/testsuite] Fix gdb.base/endianity.exp with gcc-4.8

Tom de Vries tdevries@suse.de
Sat Dec 19 15:41:46 GMT 2020


On 12/19/20 2:42 PM, Simon Marchi wrote:
>> +    set result [remote_exec host $obj]
> 
> I think this should be "remote_exec target"?
> 

Ah yes, thanks for spotting that.

> Can you remind me why you need to check for __GNUC__ support, and
> not simply for SSO support?
> 

Because of the usage of the macros __BYTE_ORDER__ and
__ORDER_LITTLE_ENDIAN__ , these are gnu c extensions (
https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html ).

I'll commit with the remote_exec fixed.

Thanks,
- Tom

> Otherwise, that LGTM.
> 
> Simon
> 


More information about the Gdb-patches mailing list