[PATCH] Use DW_FORM_exprloc in testsuite Dwarf Assembler for DWARF version 4+.
Simon Marchi
simark@simark.ca
Mon Dec 14 19:30:12 GMT 2020
On 2020-12-14 2:21 p.m., Mark Wielaard wrote:
> On Mon, 2020-12-14 at 13:11 -0500, Simon Marchi wrote:
>> I compared the .S output of a test with and without the patch, and
>> the
>> only changes I see are:
>>
>> - .uleb128 0x09 /* SPECIAL_expr */
>> + .uleb128 0x18 /* SPECIAL_expr */
>>
>> ... so that looks good. A minor improvement would be to make the
>> comment say DW_FORM_block or DW_FORM_exprloc instead of SPECIAL_expr,
>> but that's separate from this patch, so this patch LGTM as-is.
>
> Thanks, pushed.
>
> As for updating the comment, how about the attached?
>
> Cheers,
>
> Mark
>
Awesome, thanks, LGTM.
Simon
More information about the Gdb-patches
mailing list