[PATCH] Use expression completer for "maint print type"

Andrew Burgess andrew.burgess@embecosm.com
Mon Dec 7 12:51:46 GMT 2020


* Tom Tromey <tromey@adacore.com> [2020-12-03 07:32:26 -0700]:

> I happened to notice that expression completion did not work correctly
> for "maint print type".  This patch adds the appropriate completer
> there.
> 
> gdb/ChangeLog
> 2020-12-03  Tom Tromey  <tromey@adacore.com>
> 
> 	* maint.c (_initialize_maint_cmds): Use expression command
> 	completer for "maint print type".

LGTM.

Thanks,
Andrew

> ---
>  gdb/ChangeLog | 5 +++++
>  gdb/maint.c   | 3 ++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/maint.c b/gdb/maint.c
> index e8cdda3da0e..56319600ed8 100644
> --- a/gdb/maint.c
> +++ b/gdb/maint.c
> @@ -1193,11 +1193,12 @@ If nonzero, will cause the execution space for each command to be\n\
>  displayed, following the command's output."),
>  	   &maintenancelist);
>  
> -  add_cmd ("type", class_maintenance, maintenance_print_type, _("\
> +  cmd = add_cmd ("type", class_maintenance, maintenance_print_type, _("\
>  Print a type chain for a given symbol.\n\
>  For each node in a type chain, print the raw data for each member of\n\
>  the type structure, and the interpretation of the data."),
>  	   &maintenanceprintlist);
> +  set_cmd_completer (cmd, expression_completer);
>  
>    add_cmd ("statistics", class_maintenance, maintenance_print_statistics,
>  	   _("Print statistics about internal gdb state."),
> -- 
> 2.26.2
> 


More information about the Gdb-patches mailing list