[PATCH] gdb:Add new 'print binary-groups' feature

[Enze Li]

On 2020/12/4 4:13 上午, Tom Tromey wrote:
>>>>>> ">" == Enze Li via Gdb-patches <gdb-patches@sourceware.org> writes:
>>> Make an introduction of a new print setting that can be set by
>>> 'set print binary-groups [on|off]'.  The default value is OFF, and
>>> it would be changed by users manually.
> Seems like a reasonable feature to me.
>
>>> gdb/doc/ChangeLog:
>>> 	* gdb.texinfo: Document 'set/show print binary-groups'.
> Eli will have to approve the documentation change.
>  
>>> +	      if (options->binary_group_print && seen_a_one && i%4 == 0)
> The gdb style requires spaces around the "%" operator.
>
>>> +	      if (options->binary_group_print && seen_a_one && i%4 == 0)
> Here too.
>
> The rest looks good to me.  Thank you for doing this.
>
> I didn't look - do you have a copyright assignment in place with the
> FSF?  If not, contact me off-list so we can get started on this.
>
> Tom

Thanks for the review.

Fixed.

Enze