[PATCH] Remove redundant typedefs
Tom Tromey
tromey@adacore.com
Fri Dec 4 20:08:50 GMT 2020
>> @@ -794,7 +794,7 @@ struct breakpoint
>> gdbpy_breakpoint_object *py_bp_object = NULL;
>>
>> /* Same as py_bp_object, but for Scheme. */
>> - gdbscm_breakpoint_object *scm_bp_object = NULL;
>> + breakpoint_smob *scm_bp_object = NULL;
Simon> In this case, I think it would make sense to keep the
Simon> "gdbscm_breakpoint_object" name, first for symmetry with Python, but
Simon> also because it's more descriptive than "breakpoint_smob", when you are
Simon> not in the guile code.
Makes sense.
Simon> Since the code in scm-breakpoint.c uses breakpoint_smob everywhere (and
Simon> in the context of guile, it's clear what a _smob is), you could just add
Simon> a
Simon> using breakpoint_smob = gdbscm_breakpoint_object;
Simon> in that file.
I just backed out this one specific change instead.
Tom
More information about the Gdb-patches
mailing list