[PATCH 10/13] Use gdb_bfd_sections in restore_command

[Simon Marchi]

On 2020-08-28 12:23 p.m., Tom Tromey wrote:
> This changes restore_command to avoid bfd_map_over_sections, in favor
> of iteration.  A helper data structure can also be removed by this
> patch.
> 
> gdb/ChangeLog
> 2020-08-28  Tom Tromey  <tom@tromey.com>
> 
> 	* cli/cli-dump.c (struct callback_data): Remove.
> 	(restore_one_section): Rename from restore_section_callback.
> 	Change parameters.
> 	(restore_binary_file): Change parameters.
> 	(restore_command): Use foreach.

Warnings I got while applying:

Applying: Use gdb_bfd_sections in restore_command
.git/rebase-apply/patch:44: trailing whitespace.
  if (sec_end <= load_start
.git/rebase-apply/patch:76: trailing whitespace.
			       + sec_offset + load_offset),
.git/rebase-apply/patch:86: trailing whitespace.
  ret = target_write_memory (sec_start + sec_offset + load_offset,
.git/rebase-apply/patch:178: trailing whitespace.
	  load_start =
.git/rebase-apply/patch:198: trailing whitespace.
		     (unsigned long) load_start,
warning: 5 lines add whitespace errors.

Simon