[PATCH v2 0/3] Support frames inlined in outer frames
Andrew Burgess
andrew.burgess@embecosm.com
Fri Aug 28 08:50:56 GMT 2020
* Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> [2020-08-27 16:57:21 -0400]:
> This is essentially a v2 of this thread here:
>
> https://sourceware.org/pipermail/gdb-patches/2020-March/166786.html
>
> In summary, this is what the patches do:
>
> 1. fixes a latent bug that triggered when trying to unwind a frame
> inlined in the outer frame
> 2. changes how outer frames are represented
> 3. allows frames inlined in outer frames, adds a test that runs on
> regular hardware
>
> I don't see any regression on x86-64. I tested previous iterations of
> the series (with similar code) on aarch64 too and didn't see any
> regression.
I took a look through all these patches, and they all look good to me.
Thanks,
Andrew
>
> Scott Linder (1):
> gdb: support frames inlined into the outer frame
>
> Simon Marchi (2):
> gdb: make frame_unwind_got_optimized return a not_lval value
> gdb: introduce explicit outer frame id kind
>
> gdb/frame-unwind.c | 14 +-
> gdb/frame-unwind.h | 3 +
> gdb/frame.c | 21 +--
> gdb/frame.h | 9 +-
> gdb/inline-frame.c | 4 -
> .../gdb.dwarf2/dw2-reg-undefined.exp | 12 ++
> .../gdb.dwarf2/frame-inlined-in-outer-frame.S | 137 ++++++++++++++++++
> .../frame-inlined-in-outer-frame.exp | 114 +++++++++++++++
> 8 files changed, 281 insertions(+), 33 deletions(-)
> create mode 100644 gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.S
> create mode 100644 gdb/testsuite/gdb.dwarf2/frame-inlined-in-outer-frame.exp
>
> --
> 2.28.0
>
More information about the Gdb-patches
mailing list