[PATCH v2 0/3] Support frames inlined in outer frames
Pedro Alves
pedro@palves.net
Thu Aug 27 21:44:50 GMT 2020
On 8/27/20 9:57 PM, Simon Marchi via Gdb-patches wrote:
> This is essentially a v2 of this thread here:
>
> https://sourceware.org/pipermail/gdb-patches/2020-March/166786.html
>
> In summary, this is what the patches do:
>
> 1. fixes a latent bug that triggered when trying to unwind a frame
> inlined in the outer frame
> 2. changes how outer frames are represented
> 3. allows frames inlined in outer frames, adds a test that runs on
> regular hardware
>
> I don't see any regression on x86-64. I tested previous iterations of
> the series (with similar code) on aarch64 too and didn't see any
> regression.
This all LGTM. Feel free to push with the nits I pointed out on
patches #1 and #2 addressed.
For the record, I was involved in discussions about this with Simon and
the AMD folks as this went through multiple potential solutions before
settling here. I think this ended up being quite nice and clean.
Thanks,
Pedro Alves
More information about the Gdb-patches
mailing list