[PATCH v2] Enable gdb.cp/ambiguous.exp with GCC and clang

Gary Benson gbenson@redhat.com
Thu Aug 27 10:39:01 GMT 2020


Luis Machado wrote:
> On 8/25/20 11:21 AM, Gary Benson via Gdb-patches wrote:
> > Pedro Alves wrote:
> > > On 8/17/20 2:24 PM, Gary Benson wrote:
> > > > Pedro Alves wrote:
> > > > > On 7/27/20 2:09 PM, Gary Benson via Gdb-patches wrote:
> > > > > > +    unsupported "compiler does not support -Wno-inaccessible-base"
> > > > > 
> > > > > How about instead of bailing out, use "-Wno-inaccessible-base"
> > > > > with GCC >= 10, and use "-w" with older GCCs?
> > > > 
> > > > Sure.  How about this?
> > > 
> > > OK.
> > 
> > Thanks, I pushed it.
> 
> I get the following, under Ubuntu 18.04 (GCC 7.x) with this commit...
> 
> FAIL: gdb.cp/ambiguous.exp: print x.x
> FAIL: gdb.cp/ambiguous.exp: print n.x
> FAIL: gdb.cp/ambiguous.exp: print j.x
> FAIL: gdb.cp/ambiguous.exp: print jva1.x
> FAIL: gdb.cp/ambiguous.exp: print jva2.x
> FAIL: gdb.cp/ambiguous.exp: print (A1)j
> FAIL: gdb.cp/ambiguous.exp: print (A1)jva1
> 
> Is the test really supposed to run with older GCC's?

Maybe not.  Though, I don't know what version of GCC it ought to start
working on, so it's hard to know what to do.  I could leave the "-w"
in for GCC < 10, and add an extra check to make it bail out for GCC
<= your version, Luis?  With a suitable comment to mention that that's
not set in stone?

Thanks,
Gary

-- 
Gary Benson - he / him / his
Principal Software Engineer, Red Hat



More information about the Gdb-patches mailing list