[PATCH 22/22] gdb: remove TYPE_ENDIANITY_NOT_DEFAULT

[Simon Marchi]

From: Simon Marchi <simon.marchi@polymtl.ca>

gdb/ChangeLog:

	* gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): Remove, replace all
	uses with type::endianity_is_not_default.

Change-Id: I61956093c8ce6703299e913746ba91313108a0f2
---
 gdb/gdbtypes.c |  6 +++---
 gdb/gdbtypes.h | 10 ++++------
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 93d792bef2c..9cb03614e30 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -3701,7 +3701,7 @@ enum bfd_endian
 type_byte_order (const struct type *type)
 {
   bfd_endian byteorder = gdbarch_byte_order (get_type_arch (type));
-  if (TYPE_ENDIANITY_NOT_DEFAULT (type))
+  if (type->endianity_is_not_default ())
     {
       if (byteorder == BFD_ENDIAN_BIG)
         return BFD_ENDIAN_LITTLE;
@@ -3987,7 +3987,7 @@ check_types_equal (struct type *type1, struct type *type2,
       || TYPE_LENGTH (type1) != TYPE_LENGTH (type2)
       || type1->is_unsigned () != type2->is_unsigned ()
       || type1->has_no_signedness () != type2->has_no_signedness ()
-      || TYPE_ENDIANITY_NOT_DEFAULT (type1) != TYPE_ENDIANITY_NOT_DEFAULT (type2)
+      || type1->endianity_is_not_default () != type2->endianity_is_not_default ()
       || type1->has_varargs () != type2->has_varargs ()
       || type1->is_vector () != type2->is_vector ()
       || TYPE_NOTTEXT (type1) != TYPE_NOTTEXT (type2)
@@ -5068,7 +5068,7 @@ recursive_dump_type (struct type *type, int spaces)
     {
       puts_filtered (" TYPE_NOSIGN");
     }
-  if (TYPE_ENDIANITY_NOT_DEFAULT (type))
+  if (type->endianity_is_not_default ())
     {
       puts_filtered (" TYPE_ENDIANITY_NOT_DEFAULT");
     }
diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
index 2a9ac1b3c2d..ff178da68f9 100644
--- a/gdb/gdbtypes.h
+++ b/gdb/gdbtypes.h
@@ -210,12 +210,6 @@ enum type_instance_flag_value : unsigned
 
 DEF_ENUM_FLAGS_TYPE (enum type_instance_flag_value, type_instance_flags);
 
-/* * A compiler may supply dwarf instrumentation
-   that indicates the desired endian interpretation of the variable
-   differs from the native endian representation. */
-
-#define TYPE_ENDIANITY_NOT_DEFAULT(t) ((t)->endianity_is_not_default ())
-
 /* * Not textual.  By default, GDB treats all single byte integers as
    characters (or elements of strings) unless this flag is set.  */
 
@@ -1149,6 +1143,10 @@ struct type
     this->main_type->m_flag_fixed_instance = is_fixed_instance;
   }
 
+  /* A compiler may supply dwarf instrumentation that indicates the desired
+     endian interpretation of the variable differs from the native endian
+     representation. */
+
   bool endianity_is_not_default () const
   {
     return this->main_type->m_flag_endianity_not_default;
-- 
2.28.0