[PATCH] gdb: fix IA64 build failure of linux-nat
Sergei Trofimovich
slyfox@gentoo.org
Sun Aug 16 08:45:21 GMT 2020
On Tue, 19 May 2020 15:00:41 -0700
Kevin Buettner <kevinb@redhat.com> wrote:
> On Tue, 19 May 2020 22:27:10 +0100
> Sergei Trofimovich via Gdb-patches <gdb-patches@sourceware.org> wrote:
>
> > From: Sergei Trofimovich <siarheit@google.com>
> >
> > On IA64 built failed as:
> >
> > ```
> > ia64-linux-nat.c:352:29: error: 'gdbarch_num_regs' was not declared in this scope
> > 352 | if (regno < 0 || regno >= gdbarch_num_regs (gdbarch))
> > | ^~~~~~~~~~~~~~~~
> > ```
> >
> > The fix includes "gdbarch.h" header where symbol is declared.
> >
> > * gdb/ia64-linux-nat.c: include "gdbarch.h" to declare used
> > 'gdbarch_num_regs'.
>
> Okay, but please capitalize "include" in the ChangeLog entry prior
> to pushing this change.
Attached v2-* patch with capitalization changes.
I don't have a 'gdb' write access yet (I think), but I do have GCC one.
Should I request 'gdb' access as well as specified in
https://sourceware.org/cgi-bin/pdw/ps_form.cgi ?
Thank you for the review!
--
Sergei
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-0001-gdb-fix-IA64-build-failure-of-linux-nat.patch
Type: text/x-patch
Size: 1564 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20200816/f9650066/attachment.bin>
More information about the Gdb-patches
mailing list