[PATCH v2 1/2] gdb: Implement native dumpcore function

[Kamil Rytarowski]

On 05.08.2020 18:23, Tom Tromey wrote:
>>>>>> "Kamil" == Kamil Rytarowski <n54@gmx.com> writes:
>
> Kamil> Add new API for systems with native kernel support for dumping
> Kamil> a process on demand. Wire it into the gdb's gcore functionality.
>
> Kamil> gdb/ChangeLog:
>
> Kamil>        * target.h (supports_native_dumpcore, native_dumpcore): New
> Kamil>        function declarations.
> Kamil>        * target.c (supports_native_dumpcore, native_dumpcore): New
> Kamil>        functions.
> Kamil>        * target-delegates.c: Rebuild.
> Kamil>        * gcore.c (gcore_command): Use target_supports_native_dumpcore ()
> Kamil>        and target_native_dumpcore ().
>
> Thank you for the patch.
>
> Kamil> +    /* Generate the core file with native target API.  */
> Kamil> +    virtual bool dumpcore (const char *filename)
> Kamil> +      TARGET_DEFAULT_RETURN (false);
>
> There doesn't seem to be a reason to have a bool return here.
> The value isn't documented or used.
>

I've decided to remove the value in the follow up patchset.

> Tom
>