[committed][gdb] Fix prop->const_val uses in gdbtypes.c

[Simon Marchi]

On 2020-08-05 6:33 a.m., Tom de Vries wrote:
> [ was: Re: [PATCH 3/3] gdb: remove TYPE_DYN_PROP_ADDR ]
> 
> On 8/5/20 11:20 AM, Tom de Vries wrote:
>> On 8/2/20 1:59 AM, Simon Marchi via Gdb-patches wrote:
>>> Remove TYPE_DYN_PROP_ADDR, replacing its uses with calling
>>> dynamic_prop::const_val directly.
>>>
>>> gdb/ChangeLog:
>>>
>>> 	* gdbtypes.h (TYPE_DYN_PROP_ADDR): Remove, replace uses with
>>> 	dynamic_prop::const_val.
>>>
>>
>>
>> This patch causes the following regression for me:
>> ...
>> FAIL: gdb.fortran/class-allocatable-array.exp: print this%_data%b
>> ...
>> (and 185 more, all for fortran test-cases).
>>
>>>    return (prop != nullptr && prop->kind () == PROP_CONST
>>> -	  && !TYPE_DYN_PROP_ADDR (prop));
>>> +	  && prop->const_val () != 0);
>>>  }
>>>
>>
>> Hmm, isn't that supposed to be "== 0" ?
> 
> Committed patch that fixes the regressions.
> 
> Thanks,
> - Tom
> 

Arggh, thanks for fixing this.

Simon