[PATCH 0/5] Remove support for old FreeBSD hosts

[John Baldwin]

On 7/20/20 10:31 AM, John Baldwin wrote:
> The kinfo_get_file change could perhaps use further refinement.  We
> need a configure check to pick up the correct library (libutil on
> FreeBSD and libutil-freebsd on GNU/kFreeBSD).  However, the
> kinfo_get_file and kinfo_get_vmmap functions were added to this
> library at the same time (same SVN commit in FreeBSD), so checking for
> both is redundant.  Right now we check for kinfo_get_file in
> gdbsupport since filestuff.c uses it if present.  We could remove the
> check for kinfo_get_vmmap entirely from gdb/configure.ac if we think
> the kinfo_get_file check in gdbsupport/common.m4 is sufficient.  If
> so, I might need to at least move the comment from configure.ac over
> to common.m4 with some modifications.

Tom, I am curious for your input on this question at least.  You happened
to move the check for kinfo_get_file as part of the gdbsupport/ changes
earlier.  If the two checks were still on gdb's configure.ac I would
probably collapse them into one, and I would also probably not bother
defining a HAVE_FOO constant at all but just get configure to search
for the right library.  However, for filestuff.c the check in common.m4
including a HAVE_FOO is correct.  My question is if I should remove the
kinfo_get_vmmap from gdb's configure.ac entirely and depend on gdbsupport
to add the link dependency on the library or if I should keep a check in
gdb's configure.ac (but perhaps modify it to not set HAVE_FOO?).

-- 
John Baldwin