[PATCH 11/11] Update test cases that work with minimal encodings

Tom de Vries tdevries@suse.de
Thu Apr 30 06:45:58 GMT 2020


On 28-04-2020 17:35, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> On 08-04-2020 19:54, Tom Tromey wrote:
>>> -    gdb_test "ptype x" \
>>> +    gdb_test_multiple "print x" "" {
>>> +	-re -wrap $pass_re {
>>> +	    pass $gdb_test_name
>>> +	}
>>> +	-re -wrap $kfail_re {
>>> +	    if {$scenario == "minimal"} {
>>> +		setup_kfail "gnat compiler bug" *-*-*
>>> +	    }
>>> +	    fail $gdb_test_name
>>> +	}
>>> +    }
> 
> Tom> The wording "gnat compiler bug" suggest that this is an xfail (a problem
> Tom> in the environment), not a kfail (a problem in the tool, in other words,
> Tom> gdb).
> 
> I can change it.  I never really get the point of this xfail/kfail difference.
> 

Well, AFAIU, typically a gdb developer will try to drive down FAILs and
KFAILs in the gdb testsuite, but cannot do anything about XFAILs.

IMO the naming does not help.  I've sent out an RFC to add aliases
gdbfail/envfail (
https://sourceware.org/pipermail/gdb-patches/2020-April/168102.html ).

Thanks,
- Tom


More information about the Gdb-patches mailing list