[PATCH] gdb: fix duplicate test names in gdb.base/break.exp

Simon Marchi simark@simark.ca
Wed Apr 29 20:35:28 GMT 2020


On 2020-04-29 4:14 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> These test names are duplicated:
> Simon>       2 PASS: gdb.base/break.exp: set breakpoint via non-integer convenience variable disallowed
> Simon>       2 PASS: gdb.base/break.exp: set convenience variable $foo to 81.5
> 
> Simon> Wrap them with `with_test_prefix`. I've actually wrapped a bit more
> Simon> tests that are related, I think it helps to give the test names a bit
> Simon> more context.  The modified test names are:
> 
> Seems like a good idea to me.
> Thanks.
> 
> Tom
> 

Thanks, I pushed it.

Simon


More information about the Gdb-patches mailing list