[PATCH] Add definitions of system calls to catch in native NetBSD targets

Simon Marchi simark@simark.ca
Tue Apr 28 18:05:15 GMT 2020


On 2020-04-20 12:00 p.m., Kamil Rytarowski wrote:
> All platforms on NetBSD use a shared system call table, so use a
> single XML file to describe the system calls available on each NetBSD
> platform.
> 
> gdb/ChangeLog:
> 
>        * syscalls/update-netbsd.sh: New file.
>        * syscalls/netbsd.xml: Regenerate.
>        * data-directory/Makefile.in: Register `netbsd.xml' in
>        `SYSCALLS_FILES'

Can you make sure that the shell script is shellcheck-clean?  Right now it generates
a single warning:

$ shellcheck update-netbsd.sh

In update-netbsd.sh line 72:
}' $1 >> netbsd.xml.tmp
   ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean:
}' "$1" >> netbsd.xml.tmp

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

Otherwise that LGTM.

Simon


More information about the Gdb-patches mailing list