[PATCH 00/10] Fix two name-related bugs in DWARF reader

Tom de Vries tdevries@suse.de
Fri Apr 24 14:18:43 GMT 2020


On 25-03-2020 21:07, Tom Tromey wrote:
> I started this series by trying to fix PR rust/25025.  This showed
> that the Rust compiler sometimes emits two mangled forms that demangle
> to the same thing.
> 
> In the end I could maybe have fixed this in a direct way (see patch #9
> for the details), but while debugging I went on a detour into the
> physname code and came up with this series.
> 
> This changes the DWARF reader to avoid demangling when constructing
> partial symbols.  This obsoletes my previous patch to do the same
> thing; I think this approach is cleaner.
> 
> It also attempts to fix the longstanding physname bug, PR 12707.
> After this series, the demangled form is now stored on the symbol
> again.
> 
> Regression tested by the buildbot.

As extra data point, I've build and tested this series, and got
unexpected failures reduced from 8 to 1:
...
                === gdb Summary ===

# of expected passes            78972
# of unexpected failures        1
# of expected failures          135
# of known failures             72
# of untested testcases         24
# of unsupported tests          77
...

Thanks,
- Tom


More information about the Gdb-patches mailing list