[PATCH] Move OpenBSD-only functions from inf-ptrace to obsd-nat
Tom Tromey
tom@tromey.com
Thu Apr 16 20:07:15 GMT 2020
>>>>> ">" == Kamil Rytarowski <n54@gmx.com> writes:
>> All major BSDs implement PT_GET_PROCESS_STATE, but they differ in
>> details and want to implement follow-fork functionality differently.
>> gdb/ChangeLog:
>> * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
>> (remove_fork_catchpoint, post_startup_inferior)
>> (post_attach): Move...
I guess these aren't used on Linux, but what about rs6000-nat.c? Those
are the only non-BSD users of inf_ptrace_target that I can see.
I'm not a big fan of the current code, because makes methods conditional
on this define. It would be better I guess to have an intermediate
subclass for this situation. That would make it clear what code does or
does not rely on this.
You don't have to do that, but I don't think we can put this in without
knowing about the rs6000-nat case.
Tom
More information about the Gdb-patches
mailing list