[PATCH] Fix debugging of WOW64 processes

Tom Tromey tom@tromey.com
Thu Apr 9 21:15:56 GMT 2020


>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:

Hannes> Also, ignore_first_breakpoint is used now in nat/windows-nat.c as well,
Hannes> but was not available there.

Sorry about that.

Hannes> 2020-04-09  Hannes Domani  <ssbssa@yahoo.de>

Hannes> 	* nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
Hannes> 	Move to...
Hannes> 	* nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
Hannes> 	... here.
Hannes> 	* windows-nat.c (windows_nat_target::get_windows_debug_event):
Hannes> 	Check for STATUS_WX86_BREAKPOINT.
Hannes> 	(windows_nat_target::wait): Same.

Hannes>  	  && (current_event.u.Exception.ExceptionRecord.ExceptionCode
Hannes> -	      == EXCEPTION_BREAKPOINT)
Hannes> +	      == EXCEPTION_BREAKPOINT
Hannes> +	      || current_event.u.Exception.ExceptionRecord.ExceptionCode
Hannes> +	      == STATUS_WX86_BREAKPOINT)

This needs extra parens and indentation like

	  && (current_event.u.Exception.ExceptionRecord.ExceptionCode
	      == EXCEPTION_BREAKPOINT)
	      == EXCEPTION_BREAKPOINT
	      || (current_event.u.Exception.ExceptionRecord.ExceptionCode
	          == STATUS_WX86_BREAKPOINT)

Hannes>  		  && (current_event.u.Exception.ExceptionRecord.ExceptionCode
Hannes> -		      == EXCEPTION_BREAKPOINT)
Hannes> +		      == EXCEPTION_BREAKPOINT
Hannes> +		      || current_event.u.Exception.ExceptionRecord.ExceptionCode
Hannes> +		      == STATUS_WX86_BREAKPOINT)

Likewise.  Ok with this fix.

Tom


More information about the Gdb-patches mailing list