[PATCH 00/31] Turn gdbserver's linux low targets into classes
Aktemur, Tankut Baris
tankut.baris.aktemur@intel.com
Thu Apr 2 07:33:52 GMT 2020
On Wednesday, April 1, 2020 11:17 PM, Pedro Alves wrote:
> On 3/6/20 9:31 PM, Tankut Baris Aktemur wrote:
>
> > This is a series that converts the linux low target definitions of
> > gdbserver into classes that derive from 'linux_process_target'.
>
> This is excellent, thanks much for doing this. Excellent work
> splitting things up, and I like how you used the pattern
> of calling the low virtual methods "low_xxx", like gdb/linux-nat.h does.
>
> Other than the two patches I replied to, this all looks great to me.
>
> Thanks,
> Pedro Alves
Thank you for the thorough reviews. I'll push after fixing those two things.
-Baris
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
More information about the Gdb-patches
mailing list