[PATCH 10/31] gdbserver/linux-low: turn 'breakpoint_kind_from_{pc, current_state}' into methods

Pedro Alves palves@redhat.com
Wed Apr 1 19:15:50 GMT 2020


On 3/6/20 9:31 PM, Tankut Baris Aktemur wrote:
> @@ -257,7 +259,7 @@ riscv_breakpoint_kind_from_pc (CORE_ADDR *pcptr)
>      }
>    buf;
>  
> -  if (target_read_memory (*pcptr, buf.bytes, sizeof (buf.insn)) == 0
> +  if (read_memory (*pcptr, buf.bytes, sizeof (buf.insn)) == 0

Is this really correct?  It seems like an unrelated change.
target_read_memory masks off breakpoint instructions, while read_memory
doesn't, I believe.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list