[PATCH] Improve some comments about msymbol handling

Christian Biesinger via gdb-patches gdb-patches@sourceware.org
Mon Sep 30 16:23:00 GMT 2019


On Mon, Sep 30, 2019 at 11:08 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
>
> Christian>      * minsyms.h (msymbol_hash): Document that this is a case-insensitive
> Christian>      hash and why.
> Christian>      * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
> Christian>      msymbol_hash, msymbol_demangled_hash>: Improve comments.
>
> Thank you.
>
> Christian> +/* Compute a hash code for the string argument. Unlike htab_hash_string,
>
> GNU style is two spaces after the period.
>
> This is ok with that change.

Thanks, pushed with that fixed.

Christian



More information about the Gdb-patches mailing list