[PATCH v5] Improve ptrace-error detection on Linux targets

Pedro Alves palves@redhat.com
Thu Sep 26 17:48:00 GMT 2019


On 9/26/19 6:32 PM, Tom Tromey wrote:
>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
> 
> Sergio> Changes from v4:
> Sergio> - Don't add 'dont_throw' optional argument to gdb_dlopen; use
> Sergio>   conventional try..catch.
> 
> Sergio> - Use snprintf when printing to 'own_buf' and make sure we don't
> Sergio>   overflow the buffer.
> 
> Thank you for doing this.
> I think this is ok, please check it in.

Please give me a bit to review before merging.  I think I spotted an issue,
but I haven't had a chance to take a look at it since before Cauldron.

Thanks,
Pedro Alves



More information about the Gdb-patches mailing list