[PATCH v2 2/8] Handle copy relocations

Tom Tromey tromey@adacore.com
Thu Sep 19 18:28:00 GMT 2019


>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Andrew> I guess I'm thinking that we could merge the core of
Andrew> lookup_minimal_symbol_text and lookup_minimal_symbol_linkage (or
Andrew> _data), and just pass in a comparison function to check for either
Andrew> text or data symbols.

Tom> Sounds good, I'll try that.  There is already a separate debug iterator,
Tom> so maybe that can be used as well.

I looked at this, but there isn't really that much to share.

IMO callbacks tend to obfuscate the code.  So I think I'd rather not do
that, if that's ok with you.

Maybe introducing an iterator over minimal symbols, given a hash, would
simplify things a bit.  But, that's not really much of a savings.

Tom



More information about the Gdb-patches mailing list