[PATCH] gdb: remove local extern declaration of cli_styling

[Simon Marchi]

On 2019-09-18 12:18 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> 	* ui-file.c: Include cli/cli-style.h.
> Simon> 	(term_cli_styling): Remove cli_styling declaration.
> 
> Thanks for doing this.
> 
> I think as a rule it's best to always have declarations in a header and
> never in the .c code.  That way they can be checked against the
> definition.

Yes, agreed.

Actually, I didn't push this patch directly, even though it seemed obvious, because
I was wondering if there was some good reason I was missing for not doing it like
this in the first place.

I pushed it now.

Simon