[PATCH][gdb/testsuite] Restore breakpoint command in ui-redirect.exp

[Tom de Vries]

[ was: Re: [RFC][gdb/testsuite] Remove breakpoint command in
gdb.base/ui-redirect.exp ]

On 04-09-19 13:48, Jan Kratochvil wrote:
> On Tue, 03 Sep 2019 19:43:44 +0200, Tom de Vries wrote:
>> I noticed a bit in gdb.base/ui-redirect.exp that sets a breakpoint
>> command on main, but then due to runto_main, the break point is deleted:
> ...
>> In the original commit ( submission here
>> https://sourceware.org/ml/gdb-patches/2010-09/msg00120.html ) there was
>> no runto_main, and the breakpoint command was not triggered either.
>>
>> Is this some artefact, and can it be removed, or is it actually testing
>> something related to redirection?
> 
> It looks to me the patch which added the "runto_main" part:
> 
> commit ca1285d17534cff3041c07ac7841288e1b3ba19c
> Author: Alan Hayward <alan.hayward@arm.com>
> Date:   Fri May 17 14:15:01 2019 +0100
>     Add debug redirect option
> 
> disabled the regression testing.
> 
> "runto_main" should be removed otherwise the testcase does not test anything
> (or it just tests less).

Attached patch fixes the problem by replacing the initial
"gdb_breakpoint main" with the runto_main, such that the breakpoint
command is preserved throughout.

OK for trunk?

Thanks,
- Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gdb-testsuite-Restore-breakpoint-command-in-ui-redirect.exp.patch
Type: text/x-patch
Size: 4977 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20190905/370230cc/attachment.bin>