[review v2] Also check for strerror_r in gdbserver
Christian Biesinger (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Thu Oct 31 23:21:00 GMT 2019
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476
......................................................................
Patch Set 2:
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476/2//COMMIT_MSG
Commit Message:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/476/2//COMMIT_MSG@11
PS2, Line 11:
6 |
7 | Also check for strerror_r in gdbserver
8 |
9 | I forgot to do this in b231e86ac9608056ea837e24d42a878927f5787a
10 |
11 > Since safe_strerror is in gdbsupport, gdbserver also needs to
12 > check for strerror_r, although it's less critical since gdbserver
13 > does not use threads as much.
14 |
15 | gdb/gdbserver/ChangeLog:
16 |
17 | 2019-10-31 Christian Biesinger <cbiesinger@google.com>
18 |
> Normally this means the check should be put into common.m4.
Oh, thanks, let me make a new patch to move it.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6a67c8543cd7a28d6dc94f5986f56abcb55727fe
Gerrit-Change-Number: 476
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Thu, 31 Oct 2019 23:21:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: comment
More information about the Gdb-patches
mailing list