[review] Convert int to bool in agent.c
Luis Machado (Code Review)
gerrit@gnutoolchain-gerrit.osci.io
Thu Oct 31 01:25:00 GMT 2019
Luis Machado has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Looks good to me, except for the nit pointed out. Thanks!
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462/1/gdb/gdbsupport/agent.c
File gdb/gdbsupport/agent.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462/1/gdb/gdbsupport/agent.c@48
PS1, Line 48:
43 | }
44 |
45 | #define DEBUG_AGENT debug_agent_printf
46 |
47 | /* Global flag to determine using agent or not. */
48 > bool use_agent = 0;
49 |
50 | /* Addresses of in-process agent's symbols both GDB and GDBserver cares
51 | about. */
52 |
53 | struct ipa_sym_addresses_common
Likewise make it "false"?
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Icb28a65fcc8c7108bcd59287e6be66bf56f8ccb5
Gerrit-Change-Number: 462
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Comment-Date: Thu, 31 Oct 2019 01:25:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
More information about the Gdb-patches
mailing list