[review] Only clear the minsym array when necessary

[Tom Tromey (Code Review)]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/442
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Thanks, this is ok with one nit fixed.
No need to re-review.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/442/1/gdb/minsyms.c 
File gdb/minsyms.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/442/1/gdb/minsyms.c@1351 
PS1, Line 1351: 
1283 | minimal_symbol_reader::install ()
     | ...
1342 |       mcount = compact_minimal_symbols (msymbols, mcount, m_objfile);
1343 |       msym_holder.reset (XRESIZEVEC (struct minimal_symbol,
1344 | 				     msym_holder.release (),
1345 | 				     mcount));
1346 | 
1347 |       /* Attach the minimal symbol table to the specified objfile.
1348 |          The strings themselves are also located in the storage_obstack
1349 |          of this objfile.  */
1350 | 
1351 |       if (m_objfile->per_bfd->minimal_symbol_count)

gdb style is to be explicit and write "!= 0" or "> 0".



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I7da994fe6747f67714e7efe9fdbb0dbc4d6ea532
Gerrit-Change-Number: 442
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Wed, 30 Oct 2019 15:18:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment