[review] Document m68k floating point feature correspondence

Tom Tromey (Code Review) gerrit@gnutoolchain-gerrit.osci.io
Fri Oct 25 21:11:00 GMT 2019


Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/281
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+1
> 
> It is a bit confusing. Was coldfire the only target supporting Floating Point registers at the time?

Nope!  I don't really know the history here.  Internally we discussed
maybe supporting an "m68k.fp" feature, but in the end decided it wasn't
worth the effort, since older versions of gdb would not support this anyway.

> I happened to noticed that we only have coldfire.core in the XML description. Are we lacking a coldfire.fp XML in GDB? Is it only provided by non-GDB stubs?

Yeah, I don't know why gdb doesn't have other XML descriptions for m68k.
In this case the "coldfire.fp" feature is coming from an XML description
that qemu supplies.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4cd86acbe3449a29ce38327524c508c206b25b8f
Gerrit-Change-Number: 281
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 25 Oct 2019 21:11:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment



More information about the Gdb-patches mailing list