[review v2] [RFC][gdb] Make script-extension strict reject unknown extensions

[Tom Tromey (Code Review)]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Thanks for the patch.

This idea seems reasonable enough to me.

I'm going to mark this "-1" since it needs documentation still (and probably NEWS).
This lets it show up as reviewed in gerrit, but shouldn't be taken to mean some
sort of rejection.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40/2//COMMIT_MSG 
Commit Message:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40/2//COMMIT_MSG@53 
PS2, Line 53: Setting script-extension to force doesn't inhibit reading:
I guess s/force/strict/ here?


https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40/2/gdb/cli/cli-cmds.c 
File gdb/cli/cli-cmds.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/40/2/gdb/cli/cli-cmds.c@624 
PS2, Line 624: script FILE, which has already been opened as STREAM.
             :    FILE_TO_OPEN is the form of FILE to use if one needs to open the file.
             :    This is provided as FILE may have been found via the source search path.
             :    An important thing to note here is that FILE may be a symlink to a file
             :    with a different or non-existing suffix, and thus one cannot infer the
             :    extension language from FILE_TO_OPEN.  */
             : 
             : static void
             : source_script_from_stream (FILE *stream, const char *file,
             : 		
The comment should be updated to document FORCE.



-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia357a4b0b1042808401578266da80919035ad576
Gerrit-Change-Number: 40
Gerrit-PatchSet: 2
Gerrit-Owner: Tom de Vries <tdevries@suse.de>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Fri, 25 Oct 2019 17:32:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment